Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][docs] Add code owners policy #11557

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Oct 29, 2024

Description

Adds code owner policy.

Link to tracking issue

Fixes #11550

@mx-psi mx-psi marked this pull request as ready for review October 29, 2024 11:45
@mx-psi mx-psi requested a review from a team as a code owner October 29, 2024 11:45
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (942f19a) to head (71aba43).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11557   +/-   ##
=======================================
  Coverage   91.53%   91.53%           
=======================================
  Files         441      441           
  Lines       23922    23922           
=======================================
  Hits        21896    21896           
  Misses       1650     1650           
  Partials      376      376           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CONTRIBUTING.md Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from dmathieu October 29, 2024 13:17
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need similar tooling to what is in contrib to populate the CODEOWNERS file?

@mx-psi
Copy link
Member Author

mx-psi commented Oct 29, 2024

Do we need similar tooling to what is in contrib to populate the CODEOWNERS file?

Yeah, I think that would be helpful, but we can work on this independently of the actual policy, right?

@mx-psi
Copy link
Member Author

mx-psi commented Oct 29, 2024

Filed #11562 for the tooling stuff

@codeboten
Copy link
Contributor

Thanks @mx-psi, yup this can be done separately

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Oct 29, 2024
@mx-psi
Copy link
Member Author

mx-psi commented Oct 30, 2024

@open-telemetry/collector-maintainers Will merge this on Monday since we had already discussed this. Please block before then if you have objections!

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that we discussed offline and may worth commenting. The approver from codeowners is "recommended" but not "required".

This is already the de facto way things work in contrib, will file a PR to clarify there as well
@mx-psi mx-psi merged commit 17d5d8f into open-telemetry:main Nov 7, 2024
36 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codeowner policy