Feature command #12014
Merged
Feature command #12014
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
|
|
bogdandrutu
reviewed
Jan 5, 2025
Signed-off-by: danish9039 <[email protected]>
…elemetry-collector into feature-command
bogdandrutu
reviewed
Jan 6, 2025
Signed-off-by: danish9039 <[email protected]>
bogdandrutu
reviewed
Jan 6, 2025
bogdandrutu
approved these changes
Jan 6, 2025
songy23
reviewed
Jan 6, 2025
Member
songy23
left a comment
songy23
left a comment
There was a problem hiding this comment.
I think this needs a changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12014 +/- ##
==========================================
+ Coverage 91.35% 91.36% +0.01%
==========================================
Files 467 467
Lines 25761 25795 +34
==========================================
+ Hits 23533 23567 +34
Misses 1810 1810
Partials 418 418 ☔ View full report in Codecov by Sentry. |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
TylerHelmuth
reviewed
Jan 9, 2025
Comment on lines
+79
to
+91
| featuregate.GlobalRegistry().VisitAll(func(g *featuregate.Gate) { | ||
| if g.ID() == args[0] { | ||
| found = true | ||
| fmt.Printf("Feature: %s\n", g.ID()) | ||
| fmt.Printf("Enabled: %v\n", g.IsEnabled()) | ||
| fmt.Printf("Stage: %s\n", g.Stage()) | ||
| fmt.Printf("Description: %s\n", g.Description()) | ||
| fmt.Printf("From Version: %s\n", g.FromVersion()) | ||
| if g.ToVersion() != "" { | ||
| fmt.Printf("To Version: %s\n", g.ToVersion()) | ||
| } | ||
| } | ||
| }) |
Member
There was a problem hiding this comment.
Doesn't block this PR, but this feature is a great use case for #7625
Signed-off-by: danish9039 <[email protected]>
TylerHelmuth
approved these changes
Jan 21, 2025
codeboten
approved these changes
Feb 5, 2025
github-merge-queue bot
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Feb 23, 2025
This reverts commit 5caf4e4. ## Which problem is this PR solving? - Since upstream PR open-telemetry/opentelemetry-collector#12014 was merged, we don't need our own command anymore ## Description of the changes - Revert previous PR ## How was this change tested? ``` $ go run ./cmd/jaeger featuregate ``` Signed-off-by: Yuri Shkuro <[email protected]>
amilbcahat
pushed a commit
to amilbcahat/jaeger
that referenced
this pull request
May 4, 2025
…gertracing#6771) This reverts commit 5caf4e4. ## Which problem is this PR solving? - Since upstream PR open-telemetry/opentelemetry-collector#12014 was merged, we don't need our own command anymore ## Description of the changes - Revert previous PR ## How was this change tested? ``` $ go run ./cmd/jaeger featuregate ``` Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: amol-verma-allen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to tracking issue
Testing
makemake testDocumentation