[extension] Error out if passed extension.Settings has incorrect type #12305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12305 +/- ##
==========================================
- Coverage 91.41% 91.39% -0.03%
==========================================
Files 467 468 +1
Lines 25583 25598 +15
==========================================
+ Hits 23387 23395 +8
- Misses 1778 1787 +9
+ Partials 418 416 -2 ☔ View full report in Codecov by Sentry. |
mx-psi
commented
Feb 6, 2025
songy23
approved these changes
Feb 6, 2025
mx-psi
commented
Feb 6, 2025
bogdandrutu
reviewed
Feb 6, 2025
Comment on lines
+41
to
+42
| set := extensiontest.NewNopSettings() | ||
| set.ID = component.NewID(factory.Type()) |
There was a problem hiding this comment.
Should we switch extensiontest.NewNopSettings() to accept a type? Also we can generate a helper like metadatatest.NewNopSettings for components that calls the extensiontest but passes the type
There was a problem hiding this comment.
Added extensiontest.NewNopSettingsWithType, PTAL!
bogdandrutu
approved these changes
Feb 7, 2025
Merged
via the queue into
open-telemetry:main
with commit Feb 7, 2025
183d7ed
51 of 54 checks passed
This was referenced Feb 10, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR makes `"go.opentelemetry.io/collector/component"` to be always
present to create component type:
```
var typ = component.MustNewType("{{ .Type }}")
```
cc @mx-psi
<!-- Issue number if applicable -->
#### Link to tracking issue
Relevant to #12305
<!--Describe what testing was performed and which tests were added.-->
#### Testing
n/a
<!--Describe the documentation added.-->
#### Documentation
n/a
<!--Please delete paragraphs that you did not use before submitting.-->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Deprecate `Create*` methods. This is a small part of #12305, but applied to all other component kinds #### Link to tracking issue Updates #12221
This was referenced Feb 13, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Creates `NewNopSettingsWithType` function on test modules and deprecates the `NewNopSettings` functions on those modules. Replace all usages of `NewNopSettings` with `NewNopSettingsWithType`. Part of #12305 but applied to all component kinds. #### Link to tracking issue Updates #12221
mx-psi
added a commit
to mx-psi/opentelemetry-collector
that referenced
this pull request
Feb 14, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Creates `NewNopSettingsWithType` function on test modules and deprecates the `NewNopSettings` functions on those modules. Replace all usages of `NewNopSettings` with `NewNopSettingsWithType`. Part of open-telemetry#12305 but applied to all component kinds. #### Link to tracking issue Updates open-telemetry#12221
This was referenced Feb 20, 2025
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Feb 20, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Remove `NewNopSettings` introduced recently cc @mx-psi <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue open-telemetry/opentelemetry-collector#12305 <!--Describe what testing was performed and which tests were added.--> #### Testing n/a <!--Describe the documentation added.--> #### Documentation n/a <!--Please delete paragraphs that you did not use before submitting.-->
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
…NopSettingsWithType` (#12452) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Add `component.Type` parameter to `NewNopSettings` And deprecate `NewNopSettingsWithType` cc @mx-psi <!-- Issue number if applicable --> #### Link to tracking issue Relevant to #12305 <!--Describe what testing was performed and which tests were added.--> #### Testing Updated <!--Describe the documentation added.--> #### Documentation Added <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explicitly error out if the passed
component.IDdoes not have a matchingcomponent.TypeLink to tracking issue
Updates #12221