[confighttp] Remove pointers from integer fields #12323
Merged
+99
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was looking through our defaults for a few
confighttp.ClientConfig
fields and found that0
disables these fields in the underlyinghttp.Transport
object, which means we don't need them to be pointers.Docs for the four fields we set in
http.Transport
here: https://pkg.go.dev/net/http#Transport.MaxIdleConnsI also stopped assigning defaults to any fields we take from
http.DefaultTransport
where setting them is a no-op since they aren't set inhttp.DefaultTransport
.Link to tracking issue
Helps unblock confighttp 1.0 from depending on #9478