Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] delete generated_status.go in case it is not required #12348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 11, 2025

Description

Delete generated_status.go if the component type doesn't require it.

Link to tracking issue

Fixes #12346

@atoulme atoulme requested review from bogdandrutu, dmitryax and a team as code owners February 11, 2025 06:37
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 11.53846% with 23 lines in your changes missing coverage. Please review.

Project coverage is 91.45%. Comparing base (f9562a0) to head (6705f8d).

Files with missing lines Patch % Lines
cmd/mdatagen/internal/command.go 11.53% 17 Missing and 6 partials ⚠️

❌ Your patch check has failed because the patch coverage (11.53%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12348      +/-   ##
==========================================
- Coverage   91.54%   91.45%   -0.09%     
==========================================
  Files         467      467              
  Lines       25618    25644      +26     
==========================================
+ Hits        23451    23454       +3     
- Misses       1768     1785      +17     
- Partials      399      405       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[mdatagen] Delete old generated files
2 participants