Change memorylimiter and queue full errors to carry time-after information

[bogdandrutu]

Depends on #12367

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.53%. Comparing base (0831231) to head (3924197).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
exporter/exporterqueue/queue.go	75.00%	1 Missing and 1 partial ⚠️
internal/memorylimiter/memorylimiter.go	75.00%	1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12368      +/-   ##
==========================================
- Coverage   91.54%   91.53%   -0.02%     
==========================================
  Files         467      467              
  Lines       25623    25634      +11     
==========================================
+ Hits        23456    23463       +7     
- Misses       1768     1770       +2     
- Partials      399      401       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmacd]

Suggestion:

Make ErrQueueIsFull a struct type supporting the Golang errors package's Is() and As() methods, and let the OTLP receiver translate this into a status.New(codes.ResourceExhausted, err.Error()) and the WithDetails parts itself.

type QueueIsFullError struct {
  Duration time.Duration
} 
func (e QueueIsFullError) Error() string {
  return fmt.Sprintf("sending queue is full: retry after %v", e.Duration)
}
var ErrQueueIsFull = QueueIsFullError{time.Second}

Then, allow the component to configure a specific retry-after constant via the Config struct. At runtime, inside the component, use the configured retry-after and store a queueFullErr field in the component, then the user can configure this value (e.g., self.queueFullErr = QueueIsFullError{cfg.RetryAfter}. The OTLP receiver will use e.g.,

  err := pipe.Consume(ctx, request)
  candidate := exporterqueue.QueueIsFullError{}
  if errors.As(err, &candidate) {
    gst := status.New(codes.ResourceExhausted, ...)
    if dt, err := gst.withDetails(...)
       gst = dt
    }
    return gst.Err()
  }
  // ...

 

[sfc-gh-bdrutu]

I feel that this is not a scalable solution that you are proposing unless we say there is only one error like this that we support.

[sfc-gh-bdrutu]

The reason is because if we start adding checks for 10s of types of errors in every receiver this will become a big problem to maintain.

[jmacd]

Suggested change

	if err != nil {
	panic(err)
	}