-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Support connector in metrics.go.tmpl NewMetricsBuilder #12403
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: bug_fix | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
component: mdatagen | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Fix mdatagen generated_metrics for connectors | ||
|
||
# One or more tracking issues or pull requests related to the change | ||
issues: [12402] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | ||
|
||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [api] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
// Copyright The OpenTelemetry Authors | ||
// SPDX-License-Identifier: Apache-2.0 | ||
|
||
// Generate a test metrics builder from a sample metrics set covering all configuration options. | ||
//go:generate mdatagen metadata.yaml | ||
|
||
package sampleconnector // import "go.opentelemetry.io/collector/cmd/mdatagen/internal/sampleconnector" |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
[comment]: <> (Code generated by mdatagen. DO NOT EDIT.) | ||
|
||
# sample | ||
|
||
## Resource Attributes | ||
|
||
| Name | Description | Values | Enabled | | ||
| ---- | ----------- | ------ | ------- | | ||
| map.resource.attr | Resource attribute with a map value. | Any Map | true | | ||
| optional.resource.attr | Explicitly disabled ResourceAttribute. | Any Str | false | | ||
| slice.resource.attr | Resource attribute with a slice value. | Any Slice | true | | ||
| string.enum.resource.attr | Resource attribute with a known set of string values. | Str: ``one``, ``two`` | true | | ||
| string.resource.attr | Resource attribute with any string value. | Any Str | true | | ||
| string.resource.attr_disable_warning | Resource attribute with any string value. | Any Str | true | | ||
| string.resource.attr_remove_warning | Resource attribute with any string value. | Any Str | false | | ||
| string.resource.attr_to_be_removed | Resource attribute with any string value. | Any Str | true | |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,41 @@ | ||||||
// Copyright The OpenTelemetry Authors | ||||||
// SPDX-License-Identifier: Apache-2.0 | ||||||
|
||||||
package sampleconnector // import "go.opentelemetry.io/collector/cmd/mdatagen/internal/sampleconnector" | ||||||
|
||||||
import ( | ||||||
"context" | ||||||
|
||||||
"go.opentelemetry.io/collector/cmd/mdatagen/internal/sampleconnector/internal/metadata" | ||||||
"go.opentelemetry.io/collector/component" | ||||||
"go.opentelemetry.io/collector/connector" | ||||||
"go.opentelemetry.io/collector/consumer" | ||||||
"go.opentelemetry.io/collector/pdata/pmetric" | ||||||
) | ||||||
|
||||||
// NewFactory returns a receiver.Factory for sample receiver. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
func NewFactory() connector.Factory { | ||||||
return connector.NewFactory( | ||||||
metadata.Type, | ||||||
func() component.Config { return &struct{}{} }, | ||||||
connector.WithMetricsToMetrics(createMetricsToMetricsConnector, metadata.MetricsStability)) | ||||||
} | ||||||
|
||||||
func createMetricsToMetricsConnector(context.Context, connector.Settings, component.Config, consumer.Metrics) (connector.Metrics, error) { | ||||||
return nopInstance, nil | ||||||
} | ||||||
|
||||||
var nopInstance = &nopConnector{} | ||||||
|
||||||
type nopConnector struct { | ||||||
component.StartFunc | ||||||
component.ShutdownFunc | ||||||
} | ||||||
|
||||||
func (n nopConnector) Capabilities() consumer.Capabilities { | ||||||
return consumer.Capabilities{MutatesData: false} | ||||||
} | ||||||
|
||||||
func (n nopConnector) ConsumeMetrics(context.Context, pmetric.Metrics) error { | ||||||
return nil | ||||||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.