-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pipeline ID to the error message for unused connectors. #12410
Open
sudiptob2
wants to merge
2
commits into
open-telemetry:main
Choose a base branch
from
sudiptob2:feat/8721/add-full-pipeline-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add pipeline ID to the error message for unused connectors. #12410
sudiptob2
wants to merge
2
commits into
open-telemetry:main
from
sudiptob2:feat/8721/add-full-pipeline-name
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfa89c4
to
b043489
Compare
bogdandrutu
reviewed
Feb 18, 2025
a3130ef
to
a3fc63c
Compare
bogdandrutu
reviewed
Feb 18, 2025
Thank you so much for your quick response and amazing suggestions. I have made the adjustment, let me know how it looks @bogdandrutu |
a3fc63c
to
372ab66
Compare
372ab66
to
9faed07
Compare
jmacd
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in this #8721 (comment), the error message for unused connectors currently lacks specific pipeline names, making debugging more difficult.
This PR enhances the error message by including pipeline names in the
[signal/name]
format, consistent with how they appear inconfig.yaml
. This provides a better context for identifying misconfigurations.Link to tracking issue
Related to #8721
Testing
A few scenarios and example output are given below. I will do additional testing and add unit tests if necessary.
1. Used as a receiver but not used as an exporter with 1 signal
config.yaml
Main Branch Output:
Proposed Output:
2. Plain
config.yaml
Main Branch Output:
Proposed Output:
3. Multiple pipeline
config.yaml
Main Branch Output:
Proposed Output: