Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][cmd/mdatagen] fix #12298 unit tests failures #12415

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

cuichenli
Copy link

Description

The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.

Please let me know if I’ve missed anything. Thank you!

Link to tracking issue

Fixes #12298

Testing

$ cd cmd/mdatagen 
$ go install .
$ make generate 
$ git status  # run this to check there is no change in the generated files 
$ make test

Documentation

@cuichenli cuichenli requested review from dmitryax and a team as code owners February 18, 2025 01:15
@cuichenli
Copy link
Author

@mx-psi could you please take a look? thanks!

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (bf1a374) to head (f22ea62).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12415   +/-   ##
=======================================
  Coverage   92.09%   92.09%           
=======================================
  Files         465      465           
  Lines       25173    25173           
=======================================
  Hits        23184    23184           
  Misses       1592     1592           
  Partials      397      397           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax dmitryax added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 18, 2025
@dmitryax dmitryax enabled auto-merge February 18, 2025 06:16
@bogdandrutu bogdandrutu reopened this Feb 18, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 18, 2025
auto-merge was automatically disabled February 18, 2025 15:42

Pull Request is not mergeable

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 18, 2025
@codeboten codeboten added this pull request to the merge queue Feb 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 18, 2025
@dmitryax dmitryax enabled auto-merge February 19, 2025 03:33
@dmitryax dmitryax added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 19, 2025
@cuichenli
Copy link
Author

is there anything i can do with this? or maybe someone else can cherry-pick the changes and make another pr to fix the issue? 🤔

@bogdandrutu bogdandrutu reopened this Feb 21, 2025
@bogdandrutu bogdandrutu added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Feb 21, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 22, 2025
@codeboten codeboten added this pull request to the merge queue Feb 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 22, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mdatagen: metrics.go.tmpl broken filter import
5 participants