-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][cmd/mdatagen] fix #12298 unit tests failures #12415
Open
cuichenli
wants to merge
25
commits into
open-telemetry:main
Choose a base branch
from
cuichenli:fix-mdatagen-internal-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[chore][cmd/mdatagen] fix #12298 unit tests failures #12415
cuichenli
wants to merge
25
commits into
open-telemetry:main
from
cuichenli:fix-mdatagen-internal-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mx-psi could you please take a look? thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12415 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 465 465
Lines 25173 25173
=======================================
Hits 23184 23184
Misses 1592 1592
Partials 397 397 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Feb 18, 2025
codeboten
approved these changes
Feb 18, 2025
is there anything i can do with this? or maybe someone else can cherry-pick the changes and make another pr to fix the issue? 🤔 |
bogdandrutu
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation is not working in the sample projects. I reviewed the PR that introduced these changes and found no explanation for them. I believe it’s reasonable to revert these changes, so I’ve created this PR.
Please let me know if I’ve missed anything. Thank you!
Link to tracking issue
Fixes #12298
Testing
Documentation