-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[service] Add service::telemetry::metrics::views
config key
#12433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
ef5ed73
e585082
099fbd2
7bc3cbb
c146c0c
62f85e5
f8f94a9
c9886fc
45eda44
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Use this changelog template to create an entry for release notes. | ||
|
||
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
change_type: enhancement | ||
|
||
# The name of the component, or a single word describing the area of concern, (e.g. otlpreceiver) | ||
component: service | ||
|
||
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
note: Add config key to set metric views used for internal telemetry | ||
|
||
# One or more tracking issues or pull requests related to the change | ||
issues: [10769] | ||
|
||
# (Optional) One or more lines of additional information to render under the primary note. | ||
# These lines will be padded with 2 spaces and then inserted directly into the document. | ||
# Use pipe (|) for multiline entries. | ||
subtext: | | ||
The `service::telemetry::metrics::views` config key can now be used to explicitly set the list of | ||
metric views used for internal telemetry, mirroring `meter_provider::views` in the SDK config. | ||
This can be used to disable specific internal metrics, among other uses. | ||
|
||
This key will cause an error if used alongside other features which would normally implicitly create views, such as: | ||
- not setting `service::telemetry::metrics::level` to `detailed`; | ||
- enabling the `telemetry.disableHighCardinalityMetrics` feature flag. | ||
|
||
# Optional: The change log or logs in which this entry should be included. | ||
# e.g. '[user]' or '[user, api]' | ||
# Include 'user' if the change is relevant to end users. | ||
# Include 'api' if there is a change to a library API. | ||
# Default: '[user]' | ||
change_logs: [user] |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -69,6 +69,11 @@ type MetricsConfigV030 struct { | |
// Readers allow configuration of metric readers to emit metrics to | ||
// any number of supported backends. | ||
Readers []config.MetricReader `mapstructure:"readers"` | ||
|
||
// Views allows advanced configuration of emitted metrics by setting | ||
// the list of views passed to the SDK. | ||
// This is incompatible with `level` values other than `detailed`. | ||
Views []config.View `mapstructure:"views"` | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. instead, use:
This will show that we use everything from the config. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done. I modified the SDK instantiation code to pass the modified original struct to |
||
} | ||
|
||
func (c *MetricsConfigV030) Unmarshal(conf *confmap.Conf) error { | ||
|
Uh oh!
There was an error while loading. Please reload this page.