[processor/memorylimiter] Add profiles support to memorylimiter processor #12454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <[email protected]>
jmacd
reviewed
Feb 21, 2025
Comment on lines
+109
to
+113
| // TODO: actually to be 100% sure that this is "refused" and not "dropped" | ||
| // it is necessary to check the pipeline to see if this is directly connected | ||
| // to a receiver (ie.: a receiver is on the call stack). For now it | ||
| // assumes that the pipeline is properly configured and a receiver is on the | ||
| // callstack and that the receiver will correctly retry the refused data again. |
There was a problem hiding this comment.
tangent: I wonder whether this comment (which appears 4 times now) will ever be resolved.
There was a problem hiding this comment.
Especially without an issue. Maybe replace it with an issue is the first step.
jmacd
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add profiles support to the memorylimiter processor.
Link to tracking issue
Fixes #12453