Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Add Converter and Provider support #12467

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

evan-bradley
Copy link
Contributor

@evan-bradley evan-bradley commented Feb 24, 2025

Description

Adds support for confmap Converters and Providers to mdatagen, which allows us to declare stability levels for these module types.

Helps unblock open-telemetry/opentelemetry-collector-releases#546.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (2b5fa0e) to head (1e9117c).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12467      +/-   ##
==========================================
- Coverage   92.19%   92.18%   -0.01%     
==========================================
  Files         465      465              
  Lines       25194    25171      -23     
==========================================
- Hits        23228    23205      -23     
  Misses       1570     1570              
  Partials      396      396              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is special for them vs the generic "pkg"?

@evan-bradley
Copy link
Contributor Author

As a class of module: currently only the prefix (pkg/x vs. converter/x or provider/x) which are used in the labels in the generated readme. As a target for a certain level of stability: They're like extensions, so stability doesn't apply to a particular signal.

Considering the bulk of this change is just adding two new items to a few slices, I'm more inclined to explicitly add these as opposed to come up with exceptions for existing classes or make them work for more general cases. None of the existing options are really a great fit.

@dmitryax dmitryax added this pull request to the merge queue Feb 26, 2025
Merged via the queue into open-telemetry:main with commit 8099e51 Feb 26, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants