-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mdatagen] Add Converter and Provider support #12467
[mdatagen] Add Converter and Provider support #12467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12467 +/- ##
==========================================
- Coverage 92.19% 92.18% -0.01%
==========================================
Files 465 465
Lines 25194 25171 -23
==========================================
- Hits 23228 23205 -23
Misses 1570 1570
Partials 396 396 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is special for them vs the generic "pkg"?
As a class of module: currently only the prefix ( Considering the bulk of this change is just adding two new items to a few slices, I'm more inclined to explicitly add these as opposed to come up with exceptions for existing classes or make them work for more general cases. None of the existing options are really a great fit. |
Description
Adds support for confmap Converters and Providers to mdatagen, which allows us to declare stability levels for these module types.
Helps unblock open-telemetry/opentelemetry-collector-releases#546.