Skip to content

Enable X25519MLKEM768 for TLS 1.3 #13087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable X25519MLKEM768 for TLS 1.3 #13087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87a393a
update to go 1.24.0
loganaden May 25, 2025
d558a9c
Allow X25519MLKEM768 in configtls
loganaden May 25, 2025
41b3f89
Enable X25519MLKEM768 in test as well.
loganaden May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/configtls/configtls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,4 +482,5 @@ var tlsCurveTypes = map[string]tls.CurveID{
"P384": tls.CurveP384,
"P521": tls.CurveP521,
"X25519": tls.X25519,
"X25519MLKEM768": tls.X25519MLKEM768,
}
5 changes: 5 additions & 0 deletions config/configtls/configtls_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,11 @@ func TestCurvePreferences(t *testing.T) {
expectedCurveIDs []tls.CurveID
expectedErr string
}{
{
name: "X25519MLKEM768",
preferences: []string{"X25519MLKEM768"},
expectedCurveIDs: []tls.CurveID{tls.X25519MLKEM768},
},
{
name: "X25519",
preferences: []string{"X25519"},
Expand Down
2 changes: 1 addition & 1 deletion config/configtls/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module go.opentelemetry.io/collector/config/configtls

go 1.23.0
go 1.24.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only upgrade after 1.25 release

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. I will wait for 1.25 to be out then I will update the PR. Is that OK ?


require (
github.com/foxboron/go-tpm-keyfiles v0.0.0-20250323135004-b31fac66206e
Expand Down