Skip to content

Revert to jsonpb to test theory about binary size #13373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 10, 2025

Try dropping jsoniter deps to see binary size improvement. Looks like about 1.5MiB improvement.

Before:

ls -la bin/otelcorecol_darwin_arm64
-rwxr-xr-x@ 1 bdrutu  staff  42268226 Jul 10 05:47 bin/otelcorecol_darwin_arm64

After:

ls -la bin/otelcorecol_darwin_arm64 
-rwxr-xr-x@ 1 bdrutu  staff  40598354 Jul 17 13:23 bin/otelcorecol_darwin_arm64

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@6334c5b). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pmetric/json.go 66.66% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (93.33%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13373   +/-   ##
=======================================
  Coverage        ?   91.20%           
=======================================
  Files           ?      523           
  Lines           ?    28415           
  Branches        ?        0           
=======================================
  Hits            ?    25917           
  Misses          ?     1967           
  Partials        ?      531           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu force-pushed the test-json-deps-size branch from 2c3a5e4 to c3f6b0c Compare July 17, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant