-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[confighttp] Reuse zstd reader objects #13396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ethercrow
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
ethercrow:zstd-reader-pool
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+56
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49a3fbd
to
9fb5b2f
Compare
jpkrohling
approved these changes
Jul 17, 2025
d39a418
to
4bd351e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13396 +/- ##
==========================================
- Coverage 91.48% 91.44% -0.05%
==========================================
Files 529 529
Lines 29508 29523 +15
==========================================
Hits 26996 26996
- Misses 1985 1996 +11
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4bd351e
to
38f2d1f
Compare
38f2d1f
to
a8bbbdf
Compare
dehaansa
reviewed
Jul 18, 2025
atoulme
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allocating zstd reader objects on every incoming requests leads to a lot of byte buffers being allocated and collected. The compression library recommends reusing readers to avoid these allocations.
Link to tracking issue
Fixes #11824