Skip to content

[config/configgrpc] add option to enable grpc reflection #13417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cuichenli
Copy link
Member

Description

Add one option to enable grpc server reflection. Have tested with jaeger receiver as well, it can also use the reflection config

[nix-shell:~]$  grpcurl -plaintext localhost:4317 list
grpc.reflection.v1.ServerReflection
grpc.reflection.v1alpha.ServerReflection
opentelemetry.proto.collector.logs.v1.LogsService
opentelemetry.proto.collector.metrics.v1.MetricsService
opentelemetry.proto.collector.trace.v1.TraceService


[nix-shell:~]$ grpcurl -plaintext localhost:14250 list
grpc.reflection.v1.ServerReflection
grpc.reflection.v1alpha.ServerReflection
jaeger.api_v2.CollectorService

Link to tracking issue

Fixes #4951

Testing

Documentation

@cuichenli cuichenli requested a review from a team as a code owner July 18, 2025 02:53
@cuichenli cuichenli requested a review from bogdandrutu July 18, 2025 02:53
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.51%. Comparing base (2b2f6f0) to head (0bf197e).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
config/configgrpc/configgrpc.go 40.00% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (40.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13417      +/-   ##
==========================================
- Coverage   91.51%   91.51%   -0.01%     
==========================================
  Files         528      528              
  Lines       29527    29531       +4     
==========================================
+ Hits        27023    27024       +1     
- Misses       1976     1978       +2     
- Partials      528      529       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@simskij
Copy link

simskij commented Jul 24, 2025

We are also interested in this for our https://github.com/canonical/pyroscope-operators.

@dmathieu
Copy link
Member

Could you add a test?

@cuichenli
Copy link
Member Author

Could you add a test?

added

@atoulme atoulme mentioned this pull request Jul 26, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add the option to enable server reflection on otlp grpc receiver
4 participants