Skip to content

Fix JSON unmarshal and add e2e tests #13480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 24, 2025

When Entity was added, we forgot to update the unmarshal logic. Add e2e tests so that this cannot happened in the future.

@bogdandrutu bogdandrutu requested review from mx-psi, dmathieu, a team and dmitryax as code owners July 24, 2025 18:46
@bogdandrutu bogdandrutu force-pushed the fix-unmarshal-json branch 3 times, most recently from 7cdcda1 to 0c22fb0 Compare July 24, 2025 18:51
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 72.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 91.42%. Comparing base (d1830ee) to head (d4fa552).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pdata/internal/wrapper_entityref.go 57.14% 6 Missing ⚠️
pdata/internal/wrapper_stringslice.go 0.00% 5 Missing ⚠️

❌ Your patch status has failed because the patch coverage (72.50%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13480      +/-   ##
==========================================
- Coverage   91.44%   91.42%   -0.03%     
==========================================
  Files         532      535       +3     
  Lines       29527    29575      +48     
==========================================
+ Hits        27001    27038      +37     
- Misses       1995     2003       +8     
- Partials      531      534       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu enabled auto-merge July 24, 2025 19:02
@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 24, 2025
Merged via the queue into open-telemetry:main with commit 811b19c Jul 24, 2025
55 of 57 checks passed
@bogdandrutu bogdandrutu deleted the fix-unmarshal-json branch July 24, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants