Skip to content

Fix profiles JSON unmarshaling logic for byte arrays #13483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jul 24, 2025

Add generated test values for primitive slices to ensure we test all paths.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners July 24, 2025 19:57
@bogdandrutu bogdandrutu force-pushed the add-tests-values branch 2 times, most recently from bb29809 to 37a3d7c Compare July 24, 2025 20:32
@bogdandrutu bogdandrutu enabled auto-merge July 24, 2025 20:40
@bogdandrutu bogdandrutu changed the title [chore] Generate test values for the sliece of primitives Fix profiles JSON unmarshaling logic for byte arrays Jul 24, 2025
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

Attention: Patch coverage is 27.65957% with 34 lines in your changes missing coverage. Please review.

Project coverage is 91.45%. Comparing base (811b19c) to head (35a9877).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pdata/internal/generated_wrapper_byteslice.go 0.00% 6 Missing ⚠️
pdata/internal/generated_wrapper_float64slice.go 0.00% 6 Missing ⚠️
pdata/internal/generated_wrapper_int32slice.go 0.00% 6 Missing ⚠️
pdata/internal/generated_wrapper_int64slice.go 0.00% 6 Missing ⚠️
pdata/internal/generated_wrapper_uint64slice.go 0.00% 6 Missing ⚠️
pdata/internal/generated_wrapper_stringslice.go 33.33% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (27.65%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13483   +/-   ##
=======================================
  Coverage   91.44%   91.45%           
=======================================
  Files         535      536    +1     
  Lines       29575    29590   +15     
=======================================
+ Hits        27046    27061   +15     
  Misses       1997     1997           
  Partials      532      532           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bogdandrutu bogdandrutu added this pull request to the merge queue Jul 24, 2025
Merged via the queue into open-telemetry:main with commit 467db83 Jul 24, 2025
54 of 56 checks passed
@bogdandrutu bogdandrutu deleted the add-tests-values branch July 24, 2025 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants