Clarify expected behavior on component shutdown #14166
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old text to me was ambiguous as "cleared" typically means "emptied with the contents destroyed" (i.e., like the `clear` built-in function), but the API semantics actually expect the buffer to be _flushed_. This came up [on Slack][slack_thread] and it was suggested I open a PR. [slack_thread]: https://cloud-native.slack.com/archives/C01N6P7KR6W/p1763268895514129?thread_ts=1763186839.475819&cid=C01N6P7KR6W
jade-guiton-dd
approved these changes
Nov 17, 2025
Contributor
jade-guiton-dd
left a comment
jade-guiton-dd
left a comment
There was a problem hiding this comment.
LGTM. Let's wait until after the 0.140.0 release is complete to merge this however
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14166 +/- ##
=======================================
Coverage 92.25% 92.25%
=======================================
Files 658 658
Lines 41184 41184
=======================================
+ Hits 37993 37995 +2
+ Misses 2184 2183 -1
+ Partials 1007 1006 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
approved these changes
Nov 17, 2025
songy23
added
Skip Changelog
evan-bradley
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation
The old text to me was ambiguous as "cleared" typically means "emptied with the contents destroyed" (i.e., like the
clearbuilt-in function), but the API semantics actually expect the buffer to be flushed. This came up on Slack and it was suggested I open a PR.