Skip to content

Conversation

@mterhar
Copy link
Member

@mterhar mterhar commented Nov 17, 2025

Description

Some tests broke on Main a while ago and it looks like they changed from a sizer looking at bytes to items. This commit changes it back.

Testing

The items sizer test fails sometimes due to a timing situation that doesn't happen when looking at bytes.

@mterhar mterhar requested a review from a team as a code owner November 17, 2025 21:28
@mterhar mterhar requested a review from mx-psi November 17, 2025 21:28
@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 17, 2025
@mterhar mterhar changed the title fix: switch tests back to Bytes sizer [chore] switch tests back to Bytes sizer Nov 17, 2025
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (f76ed03) to head (53ad03b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14176   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         658      658           
  Lines       41186    41186           
=======================================
  Hits        37995    37995           
  Misses       2184     2184           
  Partials     1007     1007           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants