Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions .chloggen/profile-duration.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: breaking
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a breaking change anymore. There should be 2 changelog entries.
An enhancement for the new method, and a deprecation.


# The name of the component, or a single word describing the area of concern, (e.g. receiver/otlp)
component: pkg/pdata

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: fix pprofile DurationNano to be a TypeUint64

# One or more tracking issues or pull requests related to the change
issues: [14188]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
15 changes: 4 additions & 11 deletions internal/cmd/pdatagen/internal/pdata/pprofile_package.go
Original file line number Diff line number Diff line change
Expand Up @@ -255,17 +255,10 @@ var profile = &messageStruct{
protoID: 3,
returnType: timestampType,
},
&TypedField{
fieldName: "Duration",
originFieldName: "DurationNano",
protoID: 4,
returnType: &TypedType{
structName: "Timestamp",
packageName: "pcommon",
protoType: proto.TypeUint64,
defaultVal: "0",
testVal: "1234567890",
},
&PrimitiveField{
fieldName: "DurationNano",
protoID: 4,
protoType: proto.TypeUint64,
},
&MessageField{
fieldName: "PeriodType",
Expand Down
12 changes: 6 additions & 6 deletions pdata/pprofile/generated_profile.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions pdata/pprofile/generated_profile_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading