[chore] [exporterhelper] Items based queue sizing with bounded channel #9164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9164 +/- ##
==========================================
- Coverage 91.39% 91.39% -0.01%
==========================================
Files 320 321 +1
Lines 17208 17297 +89
==========================================
+ Hits 15728 15808 +80
- Misses 1177 1183 +6
- Partials 303 306 +3 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
from
2f30103
to
0ad2efc
Compare
dmitryax
changed the title
dmitryax
changed the title
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
from
0ad2efc
to
5d5ac37
Compare
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
from
5d5ac37
to
2d04229
Compare
bogdandrutu
reviewed
Dec 21, 2023
| @@ -78,15 +84,17 @@ var ( | |||
| ) | |||
|
|
|||
| // NewPersistentQueue creates a new queue backed by file storage; name and signal must be a unique combination that identifies the queue storage | |||
| func NewPersistentQueue[T any](capacity int, dataType component.DataType, storageID component.ID, marshaler func(req T) ([]byte, error), unmarshaler func([]byte) (T, error), set exporter.CreateSettings) Queue[T] { | |||
| func NewPersistentQueue[T any](cl QueueCapacityLimiter[T], dataType component.DataType, storageID component.ID, | |||
There was a problem hiding this comment.
Is that moment when you better have a Settings struct for all these params you pass. Separate PR.
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
3 times, most recently
from
64301cb
to
b2f6084
Compare
bogdandrutu
approved these changes
Dec 21, 2023
bogdandrutu
reviewed
Dec 21, 2023
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
from
b2f6084
to
b9a69cb
Compare
dmitryax
force-pushed
the
itemized-queue-sizing-bound-channel
branch
from
b9a69cb
to
f72cb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce an option to limit the queue size by the number of items instead of number of requests. This is preliminary step for having the exporter helper v2 with a batcher sender placed after the queue sender. Otherwise, it'll be hard for the users to estimate the queue size based on the number of requests without batch processor in front of it.
This change doesn't effect the existing functionality and the items based queue limiting cannot be utilized yet.
Updates #8122
Alternative to #9147