Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUILD] Fix -Wmissing-template-arg-list-after-template-kw warning #3133

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

yashykt
Copy link
Contributor

@yashykt yashykt commented Nov 7, 2024

Fixes #3124

Changes

Fix for missing-template-arg-list-after-template-kw warning.

@yashykt yashykt requested a review from a team as a code owner November 7, 2024 00:08
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e6ee262
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/672d3d3873e4c00008b7d630

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (497eaf4) to head (e6ee262).
Report is 158 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3133      +/-   ##
==========================================
+ Coverage   87.12%   87.85%   +0.73%     
==========================================
  Files         200      195       -5     
  Lines        6109     6136      +27     
==========================================
+ Hits         5322     5390      +68     
+ Misses        787      746      -41     
Files with missing lines Coverage Δ
api/include/opentelemetry/logs/event_logger.h 90.00% <100.00%> (-2.30%) ⬇️
api/include/opentelemetry/logs/logger.h 63.05% <100.00%> (-1.53%) ⬇️
...pi/include/opentelemetry/logs/logger_type_traits.h 100.00% <100.00%> (+16.00%) ⬆️

... and 98 files with indirect coverage changes

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix.

@marcalff marcalff changed the title Fix -Wmissing-template-arg-list-after-template-kw warning [BUILD] Fix -Wmissing-template-arg-list-after-template-kw warning Nov 7, 2024
@marcalff marcalff merged commit 95d039c into open-telemetry:main Nov 7, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error with clang-19
4 participants