Skip to content

Document minimum required versions #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

markus456
Copy link

@markus456 markus456 commented Jul 27, 2025

The libraries that opentelemetry-cpp requires have minimum required versions which are higher than the ones that are natively available on the systems being tested. By listing the exact versions of the libraries, the dependencies are clearly stated which removes the guesswork from build problems.

This contribution is submitted by me as an individual.

Fixes #3560

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

The libraries that opentelemetry-cpp requires have minimum required versions which are higher than the ones that are natively available on the systems being tested. By listing the exact versions of the libraries, the dependencies are clearly stated which removes the guesswork from build problems.
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 5f4b119
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6886f348769b970008d15fd1

@markus456 markus456 marked this pull request as ready for review July 27, 2025 07:07
@markus456 markus456 requested a review from a team as a code owner July 27, 2025 07:07
Typo of authoritative.
Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.03%. Comparing base (dbd0680) to head (5f4b119).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3562      +/-   ##
==========================================
+ Coverage   90.03%   90.03%   +0.01%     
==========================================
  Files         220      220              
  Lines        7065     7069       +4     
==========================================
+ Hits         6360     6364       +4     
  Misses        705      705              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
Copy link
Member

dbarker commented Jul 27, 2025

Thanks for the PR @markus456! The changes generally look good. Just a few CI failures on the third_party_minimum file link in the DocFX check and some markdown-lint errors. Please address them and I'll approve.

The link used a relative path when the rest of them used absolue ones and the lines were above the 80 line limit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake configuration on Ubuntu 20.04 fails with v1.22.0
2 participants