Skip to content

[CONFIGURATION] File configuration - prometheus exporter builder #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2025

Conversation

marcalff
Copy link
Member

Contributes to #2481

This is a partial fix, to implement the prometheus exporter builder.

Changes

Please provide a brief description of the changes here.

  • Add a new option constructor, that ignores environment variables
  • Implement the prometheus exporter builder

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner July 27, 2025 11:51
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit a377c1c
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6886c2476e29e50008a19827

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (59e7281) to head (a377c1c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3564      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.01%     
==========================================
  Files         220      220              
  Lines        7069     7069              
==========================================
- Hits         6364     6363       -1     
- Misses        705      706       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! - minor nitpick on potential to use rule of zero.

@marcalff marcalff merged commit f993e96 into main Jul 28, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_prometheus_builder branch July 28, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants