Skip to content

[CONFIGURATION] File configuration - sdk resource #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2025

Conversation

marcalff
Copy link
Member

Contributes to #2481

Remove restrictions on resource creation.

Changes

Please provide a brief description of the changes here.

  • Remove restrictions on resource creation in the SDK.
  • With declarative configuration, resources can be created after parsing a config.yaml file, calling a resource detector is no longer the only way to build a resource.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner July 27, 2025 12:31
Copy link

netlify bot commented Jul 27, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e1c66bc
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68861c2c83e63e00086c3ba0

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (dbd0680) to head (e1c66bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3567      +/-   ##
==========================================
- Coverage   90.03%   90.02%   -0.00%     
==========================================
  Files         220      220              
  Lines        7065     7069       +4     
==========================================
+ Hits         6360     6363       +3     
- Misses        705      706       +1     
Files with missing lines Coverage Δ
sdk/include/opentelemetry/sdk/resource/resource.h 100.00% <100.00%> (ø)
sdk/src/resource/resource.cc 96.78% <100.00%> (+0.48%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@marcalff marcalff merged commit f28ea95 into main Jul 27, 2025
70 checks passed
@marcalff marcalff deleted the merge_config_sdk_resource branch July 27, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants