Skip to content

[SqlClient] Update mssql/server test container #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martincostello
Copy link
Member

Changes

Update to the latest mssql/server image.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Update to the latest `mssql/server` image.
@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 11:58
@martincostello martincostello requested a review from a team as a code owner June 9, 2025 11:58
@github-actions github-actions bot added the comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient label Jun 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SQL Server test container to a newer patch release of the mssql/server image.

  • Bump test container image from 2022-CU14 to 2022-CU19.
Comments suppressed due to low confidence (1)

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (71655ce) to head (c28bdab).
Report is 879 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2825       +/-   ##
===========================================
+ Coverage   73.91%   87.82%   +13.91%     
===========================================
  Files         267        9      -258     
  Lines        9615      460     -9155     
===========================================
- Hits         7107      404     -6703     
+ Misses       2508       56     -2452     
Flag Coverage Δ
unittests-Instrumentation.SqlClient 87.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 270 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alanwest alanwest merged commit 5d6aa82 into open-telemetry:main Jun 12, 2025
61 checks passed
@martincostello martincostello deleted the update-sql-test-container branch June 12, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants