-
Notifications
You must be signed in to change notification settings - Fork 330
[Instrumentation.EntityFrameworkCore] Add component owners #2827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Instrumentation.EntityFrameworkCore] Add component owners #2827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds the new component owners for the EntityFrameworkCore instrumentation so that contributions and reviews are routed to the correct maintainers.
- Populates the “Code Owners” row in the EF Core README table
- Registers the two GitHub handles in the central component_owners.yml
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/README.md | Added “Code Owners” row with two new maintainers |
.github/component_owners.yml | Added martincostello and matt-hensley under the EF Core component |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2827 +/- ##
==========================================
- Coverage 73.91% 69.65% -4.26%
==========================================
Files 267 394 +127
Lines 9615 15978 +6363
==========================================
+ Hits 7107 11130 +4023
- Misses 2508 4848 +2340 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add component owners for OpenTelemetry.Instrumentation.EntityFrameworkCore. Resolves open-telemetry#888.
fa4cc31
to
94d4556
Compare
Fixes #888.
@matt-hensley and I are happy to take on the component ownership for the OpenTelemetry.Instrumentation.EntityFrameworkCore as part of our OpenTelemetry work at Grafana.
Changes
Add component owners for OpenTelemetry.Instrumentation.EntityFrameworkCore.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes