Skip to content

[Instrumentation.EntityFrameworkCore] Add component owners #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

martincostello
Copy link
Member

Fixes #888.

@matt-hensley and I are happy to take on the component ownership for the OpenTelemetry.Instrumentation.EntityFrameworkCore as part of our OpenTelemetry work at Grafana.

Changes

Add component owners for OpenTelemetry.Instrumentation.EntityFrameworkCore.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@Copilot Copilot AI review requested due to automatic review settings June 9, 2025 12:08
@martincostello martincostello requested a review from a team as a code owner June 9, 2025 12:08
@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore documentation Improvements or additions to documentation labels Jun 9, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the new component owners for the EntityFrameworkCore instrumentation so that contributions and reviews are routed to the correct maintainers.

  • Populates the “Code Owners” row in the EF Core README table
  • Registers the two GitHub handles in the central component_owners.yml

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/OpenTelemetry.Instrumentation.EntityFrameworkCore/README.md Added “Code Owners” row with two new maintainers
.github/component_owners.yml Added martincostello and matt-hensley under the EF Core component

Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.65%. Comparing base (71655ce) to head (94d4556).
Report is 879 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2827      +/-   ##
==========================================
- Coverage   73.91%   69.65%   -4.26%     
==========================================
  Files         267      394     +127     
  Lines        9615    15978    +6363     
==========================================
+ Hits         7107    11130    +4023     
- Misses       2508     4848    +2340     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 86.06% <ø> (?)
unittests-Exporter.Geneva 53.33% <ø> (?)
unittests-Exporter.InfluxDB 95.14% <ø> (?)
unittests-Exporter.Instana 74.86% <ø> (?)
unittests-Exporter.OneCollector 94.61% <ø> (?)
unittests-Exporter.Stackdriver 79.26% <ø> (?)
unittests-Extensions 90.65% <ø> (?)
unittests-Extensions.Enrichment 100.00% <ø> (?)
unittests-Instrumentation.AWS 84.01% <ø> (?)
unittests-Instrumentation.AspNet 76.79% <ø> (?)
unittests-Instrumentation.AspNetCore 70.32% <ø> (?)
unittests-Instrumentation.ConfluentKafka 14.10% <ø> (?)
unittests-Instrumentation.ElasticsearchClient 80.12% <ø> (?)
unittests-Instrumentation.EntityFrameworkCore 57.06% <ø> (?)
unittests-Instrumentation.EventCounters 76.36% <ø> (?)
unittests-Instrumentation.GrpcCore 91.42% <ø> (?)
unittests-Instrumentation.GrpcNetClient 79.61% <ø> (?)
unittests-Instrumentation.Hangfire 93.58% <ø> (?)
unittests-Instrumentation.Http 74.09% <ø> (?)
unittests-Instrumentation.Owin 88.62% <ø> (?)
unittests-Instrumentation.Process 100.00% <ø> (?)
unittests-Instrumentation.Quartz 78.76% <ø> (?)
unittests-Instrumentation.Runtime 100.00% <ø> (?)
unittests-Instrumentation.ServiceFabricRemoting 34.54% <ø> (?)
unittests-Instrumentation.SqlClient 87.82% <ø> (?)
unittests-Instrumentation.StackExchangeRedis 70.92% <ø> (?)
unittests-Instrumentation.Wcf 78.75% <ø> (?)
unittests-PersistentStorage 65.88% <ø> (?)
unittests-Resources.AWS 75.00% <ø> (?)
unittests-Resources.Azure 84.56% <ø> (?)
unittests-Resources.Container 67.34% <ø> (?)
unittests-Resources.Gcp 71.42% <ø> (?)
unittests-Resources.Host 73.91% <ø> (?)
unittests-Resources.OperatingSystem 76.98% <ø> (?)
unittests-Resources.Process 100.00% <ø> (?)
unittests-Resources.ProcessRuntime 78.26% <ø> (?)
unittests-Sampler.AWS 88.25% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 394 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Add component owners for OpenTelemetry.Instrumentation.EntityFrameworkCore.

Resolves open-telemetry#888.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.entityframeworkcore Things related to OpenTelemetry.Instrumentation.EntityFrameworkCore documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Instrumentation.EntityFrameworkCore] Component owner needed.
1 participant