Skip to content

legal: fix licenses of dependencies #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

florianl
Copy link
Contributor

Replace the costum license checker with google/go-licenses, which is already used in other OTel projects. And run the license check for dependencies as part of the CI.

This fix also makes sure, that the licenses are Go module version aware.

Replace the costum license checker with google/go-licenses, which is
already used in other OTel projects. And run the license check for
dependencies as part of the CI.

This fix also makes sure, that the licenses are Go module version aware.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl requested review from a team August 30, 2024 11:39
Copy link
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇

@florianl
Copy link
Contributor Author

florianl commented Sep 3, 2024

With f8f8db8 applied, CI is failing as expected, as the licenses where not updates https://github.com/open-telemetry/opentelemetry-ebpf-profiler/actions/runs/10683289144/job/29611021732?pr=143. This just confirms that CI tests are working as expected.

Signed-off-by: Florian Lehner <[email protected]>
Copy link
Member

@athre0z athre0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

@florianl florianl merged commit c94f780 into open-telemetry:main Sep 3, 2024
23 checks passed
@rockdaboot
Copy link
Contributor

👍 Thanks

@florianl florianl deleted the flo-legal branch September 26, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants