coredump: enable cgo warnings #613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
a013733 to
e88a47c
Compare
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
korniltsev
commented
Jul 17, 2025
| #cgo CFLAGS: -Wno-unused-label | ||
| #cgo CFLAGS: -Wno-sign-compare | ||
| #cgo CFLAGS: -Wno-unknown-pragmas | ||
| #cgo CFLAGS: -Wno-unused-parameter |
There was a problem hiding this comment.
Unfortunately can not enable this one in cgo because of golang/go#71225
There was a problem hiding this comment.
# go.opentelemetry.io/ebpf-profiler/tools/coredump
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_log':
cgo-generated-wrappers:91:43: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___push_frame':
cgo-generated-wrappers:92:46: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03_bpf_ktime_get_ns':
cgo-generated-wrappers:93:50: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03_bpf_get_current_comm':
cgo-generated-wrappers:94:54: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_probe_read_user':
cgo-generated-wrappers:95:55: error: unused parameter 'p' [-Werror=unused-parameter]
cgo-generated-wrappers: In function '_cgoexp_b173915d1d03___bpf_map_lookup_elem':
cgo-generated-wrappers:96:55: error: unused parameter 'p' [-Werror=unused-parameter]
cc1: all warnings being treated as errors
florianl
reviewed
Jul 17, 2025
This reverts commit 2174352.
korniltsev
force-pushed
the
korniltsev/coredump_warnings
branch
from
87e233e to
b8e751b
Compare
|
This should be ready for another round of review |
rockdaboot
reviewed
Jul 21, 2025
florianl
approved these changes
Jul 21, 2025
rockdaboot
reviewed
Jul 21, 2025
support/ebpf/dotnet_tracer.ebpf.c
Outdated
Comment on lines
109
to
111
| #if !defined(TESTING_COREDUMP) | ||
| #pragma unroll 256 | ||
| #endif |
There was a problem hiding this comment.
Avoid code repetition by defining a macro (e.g. UNROLL), which is empty for gcc.
Just in case, https://github.com/open-telemetry/opentelemetry-ebpf-profiler/pull/613/files#r2218507693 can't be solved to use the same compiler everywhere.
There was a problem hiding this comment.
Applied, please take a look.
rockdaboot
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wunused-parameterin the ebpf makefile(void).