-
Notifications
You must be signed in to change notification settings - Fork 317
Fix issues related to frame symbolization and add support for older V8 engines. #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Would you like to add a coredump test for a sandboxed v8 process to avoid regressions in the future? |
Okay, I'll look into how to add a coredump test. |
I looked into it, and this part of the unwind instructions comes from anonymously loaded executable code in memory (JIT/AOT compiled), so it's not possible to construct a coredump test for it. |
Anonymous pages are included in coredump. We have multiple such test cases. You can use e.g. tools/coredump utility to generate the test cases from a running process. |
I'm not sure how you did it. Even if I attach to the target process using |
Add support for frame symbolization in V8 engine's trusted sandbox mode, as well as compatibility with older versions of the V8 engine.
The frame symbolization issue under V8 engine's trusted sandbox mode can be verified by profiling the node inside the docker of
langgenius/dify-web:1.4.0
.The log for frame symbolization failure looks like this:
Bytecode positions: 0 bytes: 0xbf8965c1140 instance is 0xd4, but expected [0xba]
.