Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(oban): allow passing options to insert wrapper #318

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore(oban): allow passing options to insert wrapper #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
944e78a
chore(oban): allow passing options to insert wrapper
Miradorn Apr 24, 2024
d6ad0ca
Merge branch 'main' into main
Miradorn Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions instrumentation/opentelemetry_oban/lib/opentelemetry_oban.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,15 @@ defmodule OpentelemetryOban do
:ok
end

def insert(name \\ Oban, %Changeset{} = changeset) do
def insert(name \\ Oban, changeset, opts \\ [])
def insert(name, %Changeset{} = changeset, opts) do
attributes = attributes_before_insert(changeset)
worker = Changeset.get_field(changeset, :worker)

OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
changeset = add_tracing_information_to_meta(changeset)

case Oban.insert(name, changeset) do
case Oban.insert(name, changeset, opts) do
{:ok, job} ->
OpenTelemetry.Tracer.set_attributes(attributes_after_insert(job))
{:ok, job}
Expand All @@ -69,19 +70,19 @@ defmodule OpentelemetryOban do
end
end

def insert(name \\ Oban, multi, multi_name, changeset_or_fun) do
Oban.insert(name, multi, multi_name, changeset_or_fun)
def insert(name \\ Oban, multi, multi_name, changeset_or_fun, opts \\ []) do
Oban.insert(name, multi, multi_name, changeset_or_fun, opts)
end

def insert!(name \\ Oban, %Changeset{} = changeset) do
def insert!(name \\ Oban, %Changeset{} = changeset, opts \\ []) do
attributes = attributes_before_insert(changeset)
worker = Changeset.get_field(changeset, :worker)

OpenTelemetry.Tracer.with_span "#{worker} send", attributes: attributes, kind: :producer do
changeset = add_tracing_information_to_meta(changeset)

try do
job = Oban.insert!(name, changeset)
job = Oban.insert!(name, changeset, opts)
OpenTelemetry.Tracer.set_attributes(attributes_after_insert(job))
job
rescue
Expand All @@ -94,24 +95,24 @@ defmodule OpentelemetryOban do
end
end

def insert_all(name \\ Oban, changesets_or_wrapper)
def insert_all(name \\ Oban, changesets_or_wrapper, opts \\ [])

def insert_all(name, %{changesets: changesets}) when is_list(changesets) do
insert_all(name, changesets)
def insert_all(name, %{changesets: changesets}, opts) when is_list(changesets) do
insert_all(name, changesets, opts)
end

def insert_all(name, changesets) when is_list(changesets) do
def insert_all(name, changesets, opts) when is_list(changesets) do
# changesets in insert_all can include different workers and different
# queues. This means we cannot provide much information here, but we can
# still record the insert and propagate the context information.
OpenTelemetry.Tracer.with_span :"Oban bulk insert", kind: :producer do
changesets = Enum.map(changesets, &add_tracing_information_to_meta/1)
Oban.insert_all(name, changesets)
Oban.insert_all(name, changesets, opts)
end
end

def insert_all(name \\ Oban, multi, multi_name, changesets_or_wrapper) do
Oban.insert_all(name, multi, multi_name, changesets_or_wrapper)
def insert_all(name \\ Oban, multi, multi_name, changesets_or_wrapper, opts \\ []) do
Oban.insert_all(name, multi, multi_name, changesets_or_wrapper, opts)
end

defp add_tracing_information_to_meta(changeset) do
Expand Down
Loading