New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor integration test #449

Draft

danschultzer wants to merge 3 commits into open-telemetry:main from danschultzer:refactor-integration-test

Contributor

danschultzer commented Jan 9, 2025

Stacked on #448.

Updates the dependencies being tested with, uses Phoenix formatter rules, and refactors the integration test with the following changes:

No need to set up two ports at the same time since we only test a single endpoint for each test
Use test tags for opts/config
Detach only the telemetry handlers we know are attached
DRY setup and request handling

danschultzer added 3 commits

January 8, 2025 15:03


          Fix OpentelemetryPhoenix tests

131b6f3


          Update dependencies

044f8e6


          Refactor integration test

4a0ba46

github-actions bot added opentelemetry_phoenix elixir instrumentation labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bryannaegele Awaiting requested review from bryannaegele bryannaegele will be requested when the pull request is marked ready for review bryannaegele is a code owner

tsloughter Awaiting requested review from tsloughter tsloughter will be requested when the pull request is marked ready for review tsloughter is a code owner

At least 1 approving review is required to merge this pull request.

Labels

elixir instrumentation opentelemetry_phoenix