Skip to content

Conversation

@tushar1977
Copy link

Issue #133

Moved pkg/instrumentation to contrib and fixed the imports

@tushar1977 tushar1977 requested a review from a team as a code owner November 14, 2025 18:06
@github-actions
Copy link

The title of this pull request does not match the conventional commits format.
Please update the title, as apprioriate.

Refer to the CONTRIBUTING.md file for more information.

@tushar1977
Copy link
Author

@y1yang0 i have fixed all the imports in tools/data/*.yaml. But when i run e2e or integration test it fails
I noticed that in .otel-build repo, there is no contrib folder. So can you where the files are added?

@tushar1977 tushar1977 closed this Nov 15, 2025
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's tackle this after merging #156 and #160 It will create to many conflicts otherwise.

Also I think we should have instrumentation for the integration we (maintainers) maintain and instrumentation/contrib for the outside contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants