-
Notifications
You must be signed in to change notification settings - Fork 21
feat: support generic funcs #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Good Job! |
y1yang0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I didn't expect the implementation to be this clean and elegant
| println("Hello, Generic World!", key, value) | ||
| return value | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case func (recv *Recv[T]) GenericExample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test added.
There were some extra changes needed to support this case:
- Extract receiver type parameters
- Set hook ctx params as a combination of receiver and function types
- Preserve generics in trampolines
This new code would require some new 👀 63a9420
| clause = getParamClause(idx, paramType) | ||
| methodGetParamBody.List = append(methodGetParamBody.List, clause) | ||
| idx++ | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SetParam/SetReturnVal function is intended to modify the parameters of the original function, but the current implementation doesn't allow this. We should rewrite it to panic (or something similar) to reject user calls and make it clear this operation is unsupported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would require a extra bit of code. Do you see any direct approach?
WDYT about moving this to a new issue? This PR is starting to get big
docs/rules.md
Outdated
| This rule will inject `MyHookBefore` at the start of the `Example` function in the `main` package, and `MyHookAfter` at the end. The hook functions are located in the specified `path`. | ||
|
|
||
| **Generic Function Support:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation needs to be updated to state that SetParam and SetReturnVal cannot be used with generic hook functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can document these limitations as part of #194. They should be more related to hooks than rules itself.
| // in the linkname declaration (since linkname doesn't support generics) | ||
| for _, field := range paramTypes.List { | ||
| field.Type = replaceTypeParamsWithAny(field.Type, ip.targetFunc.Type.TypeParams) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rectifyAnyType() already does this. Why do we need to repeat it here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not exactly the same.
For example:
func (t *T) Func1(p1 string, p2 int)
The receiver trait is marked as IsInterfaceAny and replaced here, so it ends up in:
func H3Before(ctx inst.HookContext, recv interface{}, p1 string, p2 int)
TestInstrumentation_Integration/method-receiver covers this case.
However, it could be simplified 58aa8e3
2d20dee to
c318de6
Compare
Contributing to #169
More info in ☝️ issue about why Hooks use
interface{}as argument type:This PR also add the support for parameter grouping in hooks, example:
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews