Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: Fix newResource #6606

Merged
merged 7 commits into from
Jan 14, 2025
Merged

config: Fix newResource #6606

merged 7 commits into from
Jan 14, 2025

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 13, 2025

Fixes #6603

@github-actions github-actions bot requested a review from codeboten January 13, 2025 10:38
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.6%. Comparing base (640d7ea) to head (0a6bb91).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6606   +/-   ##
=====================================
  Coverage   68.6%   68.6%           
=====================================
  Files        200     200           
  Lines      16872   16872           
=====================================
  Hits       11582   11582           
  Misses      4941    4941           
  Partials     349     349           
Files with missing lines Coverage Δ
config/v0.3.0/resource.go 100.0% <100.0%> (ø)

@pellared pellared marked this pull request as ready for review January 13, 2025 10:53
@pellared pellared requested a review from a team as a code owner January 13, 2025 10:53
@pellared pellared changed the title config: Fix handling of SchemaUrl config: Fix handling of Resource Jan 13, 2025
@pellared pellared changed the title config: Fix handling of Resource config: Fix newResource Jan 13, 2025
config/v0.3.0/resource.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared pellared merged commit 43be374 into open-telemetry:main Jan 14, 2025
25 checks passed
@pellared pellared deleted the fix-6603 branch January 14, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config: newResource nil pointer dereference
4 participants