-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UnmarshalJSON method for TraceID #3682
base: main
Are you sure you want to change the base?
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3682 +/- ##
=======================================
- Coverage 79.7% 79.7% -0.1%
=======================================
Files 171 171
Lines 12673 12684 +11
=======================================
+ Hits 10105 10112 +7
- Misses 2355 2359 +4
Partials 213 213
|
See related discussion: #1819 |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Given @open-telemetry/go-maintainers WDYT? |
No concerns from me |
No concerns from me, but there were valid concerns raised in the issue mentioned above. |
I had to manually pass TraceID from my Kafka Producer to Consumer for one of my projects and realised that the UnmarshalJSON method for TraceID wasn't there.
So I had to manually convert my TraceID into a string before sending it to Kafka.
So, adding this method to the source would be helpful to avoid this extra manual work.