[chore]: enable context-as-argument from revive #6273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
mmorel-35
changed the title
mmorel-35
force-pushed
the
revive/context-as-argument
branch
2 times, most recently
from
450d871 to
0797f75
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
revive/context-as-argument
branch
from
0797f75 to
5cf2dc7
Compare
dmathieu
reviewed
Feb 6, 2025
| @@ -2,6 +2,9 @@ module go.opentelemetry.io/otel/internal/tools | |||
|
|
|||
| go 1.22.1 | |||
|
|
|||
| // TODO (#3372) remove version replacement when it is compatible. https://github.com/golangci/golangci-lint/issues/3280 | |||
| replace github.com/spf13/viper => github.com/spf13/viper v1.12.0 | |||
There was a problem hiding this comment.
How about downgrading viper down below rather than a replace? We get golangci-lint breaking changes all the time, and we ignore the renovabot PRs.
pellared
requested changes
Feb 6, 2025
There was a problem hiding this comment.
I am not in favor of downgrading some dependency given that the context-as-argument rule has not even found any issue. This can bring troubles without clear benefits.
Can you make a separate PR which just cleans the config e.g. removes disabled: false? Basically one that cleans up redundant configuration and comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up redondant configuration and mutualise comments