Skip to content

[Prototype] propagation: add EnvCarrier #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[Prototype] propagation: add EnvCarrier #6778

wants to merge 6 commits into from

Conversation

pellared
Copy link
Member

@pellared pellared commented May 15, 2025 •
edited
Loading

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 15, 2025
@pellared
Copy link
Member Author

CC @adrielp

@pellared pellared mentioned this pull request May 15, 2025
Closed
3 tasks
pellared
pellared commented May 15, 2025
View reviewed changes
pellared
pellared commented May 15, 2025
View reviewed changes
@pellared pellared mentioned this pull request May 22, 2025
Closed
pellared
pellared commented Jun 3, 2025
View reviewed changes
propagation/env.go
if len(kvPair) < 1 {
continue
}
keys = append(keys, kvPair[0])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe

Suggested change
keys = append(keys, kvPair[0])
keys = append(keys, strings.ToLower(kvPair[0]))

@adrielp adrielp mentioned this pull request Jun 10, 2025
Merged
4 tasks
github-merge-queue bot pushed a commit to open-telemetry/opentelemetry-specification that referenced this pull request Jul 8, 2025
@adrielp @pellared
@lmolkova @reyang
[spec] add supplementary guidance around env context propagation (#4548)
2bc7276 
## Changes

Adds supplementary guidance around the behaviors the SDKs should look to
implement.

* [x] Related issues
[#4470](#4470)
& #4484
* [x] Related [OTEP
0258](https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/0258-env-context-baggage-carriers.md)
* [x] Links to the prototypes (when adding or changing features)
  - [Go](open-telemetry/opentelemetry-go#6778)
-
[Python](open-telemetry/opentelemetry-python#4609)
* [x]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes

---------

Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Reiley Yang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrAlias MrAlias Awaiting requested review from MrAlias MrAlias will be requested when the pull request is marked ready for review MrAlias is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM will be requested when the pull request is marked ready for review XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole will be requested when the pull request is marked ready for review dashpole is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu will be requested when the pull request is marked ready for review dmathieu is a code owner

@flc1125 flc1125 Awaiting requested review from flc1125 flc1125 will be requested when the pull request is marked ready for review flc1125 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pellared