prometheus: validate exponential histogram scale range (#6779) #6822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highlyavailable
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
highlyavailable
force-pushed
the
fix/prometheus-exponential-histogram-scale-validation-clean
branch
from
6f10f59 to
4c1e41b
Compare
|
cc @dashpole |
MrAlias
added
the
pkg:exporter:prometheus
MrAlias
reviewed
May 26, 2025
highlyavailable
force-pushed
the
fix/prometheus-exponential-histogram-scale-validation-clean
branch
from
4c1e41b to
95c4664
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6822 +/- ##
=======================================
+ Coverage 82.3% 82.4% +0.1%
=======================================
Files 263 263
Lines 24416 24472 +56
=======================================
+ Hits 20095 20184 +89
+ Misses 3939 3908 -31
+ Partials 382 380 -2
🚀 New features to boost your workflow:
|
highlyavailable
force-pushed
the
fix/prometheus-exponential-histogram-scale-validation-clean
branch
from
332fca7 to
e058c03
Compare
Fixes open-telemetry#6779 Add scale validation for Prometheus exponential histograms to ensure compatibility with Prometheus native histogram format. Changes: - Validate scale is within Prometheus supported range [-4, 8] - Reject scales below -4 (log error and skip data point) - Downscale histograms with scale > 8 by re-aggregating buckets - Add comprehensive test coverage for scale validation and downscaling - Implement downscaling logic based on OpenTelemetry Collector Contrib The downscaling implementation merges buckets using bit-shifting to maintain accuracy while conforming to Prometheus limitations.
highlyavailable
force-pushed
the
fix/prometheus-exponential-histogram-scale-validation-clean
branch
from
e058c03 to
764b9f2
Compare
|
Hey @MrAlias, I updated my PR based on your feedback. Now there is only 1 new commit, and its passing test cases. Let me know if there are any issues with the change, and thanks for the initial feedback |
dashpole
reviewed
May 30, 2025
Removed unnecessary logic for trimming leading and trailing zeros in the downscaleExponentialBucket function.
dashpole
reviewed
Jun 9, 2025
| }) | ||
| } | ||
|
|
||
| func TestGaugeMetrics(t *testing.T) { |
There was a problem hiding this comment.
I see a couple of unrelated tests added here. Are you just trying to increase test coverage, or were these mistakenly copied from somewhere else?
There was a problem hiding this comment.
@highlyavailable, can you please respond?
dashpole
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6779
Changes
addExponentialHistogramMetricTesting
TestExponentialHistogramScaleValidationto verify error handling doesn't break normal operation