Add release artifacts signing to the release process #6855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
force-pushed
the
sign-release-docs
branch
from
c4e334e to
4166eb6
Compare
MrAlias
requested review from
XSAM,
dashpole,
pellared and
dmathieu
as code owners
dashpole
approved these changes
May 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6855 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 263 263
Lines 24416 24418 +2
=====================================
+ Hits 20095 20099 +4
+ Misses 3939 3937 -2
Partials 382 382 🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jun 2, 2025
Co-authored-by: Damien Mathieu <[email protected]>
pellared
reviewed
Jun 9, 2025
|
I have added my key (also updated the company 😉) |
XSAM
reviewed
Jun 11, 2025
XSAM
reviewed
Jun 11, 2025
| - [Tyler Yahn](https://github.com/MrAlias), Splunk | ||
| - [Robert Pająk](https://github.com/pellared), Splunk ([GPG](https://keys.openpgp.org/search?q=0xE5F7C35A4DBE90C2)) | ||
| - [Sam Xie](https://github.com/XSAM), Splunk ([GPG](https://keys.openpgp.org/search?q=AEA033782371ABB18EE39188B8044925D6FEEBEA)) | ||
| - [Tyler Yahn](https://github.com/MrAlias), Splunk ([GPG](https://pgp.mit.edu/pks/lookup?search=0x46B0F3E1A8B1BA5A)) |
There was a problem hiding this comment.
pgp.mit.edu takes 80 seconds to return. Should we use keys.openpgp.org?
There was a problem hiding this comment.
I also found it to be unusable.
pellared
reviewed
Jun 12, 2025
Co-authored-by: Robert Pająk <[email protected]>
dashpole
reviewed
Jun 12, 2025
Co-authored-by: David Ashpole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #6854