chore: unit tests for verifyreadmes #7026
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachgarash
requested review from
MrAlias,
XSAM,
dashpole,
pellared and
dmathieu
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7026 +/- ##
=====================================
Coverage 82.8% 82.8%
=====================================
Files 262 262
Lines 24343 24343
=====================================
+ Hits 20157 20158 +1
+ Misses 3811 3810 -1
Partials 375 375 🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jul 15, 2025
| t.Run(tc.name, func(t *testing.T) { | ||
| path, info := tc.setup(t, tmpDir) | ||
| got := verifyReadme(path, info, nil) | ||
| if (err != nil) != tc.want { |
There was a problem hiding this comment.
Could we check the actual error rather than its presence?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6604