Skip to content

fix: use part-of kubernetes label instead of instance in demo chart #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Machyne
Copy link

@Machyne Machyne commented Jul 7, 2025

The Kubernetes Recommended Labels docs say that instance should be a unique identifier for an instance of an application. Here, it's set to the helm installation name everywhere. I think part-of is more appropriate in this case.

Using instance creates issues when scraping service labels per the semantic conventions: since no resource.opentelemetry.io/service.name annotation is provided, this well known k8s label app.kubernetes.io/instance is checked next. The result is that all of the data from the workload pods sent through k8sattributes processor using the service.name metadata will come out with the same service.name (ex: "my-otel-demo" when using the example install command).

If you think this is an issue with the semantic conventions, please let me know and I will take this discussion to that repo instead. Thanks in advance!

(note: this is a one-line diff on charts/opentelemetry-demo/templates/_helpers.tpl plus the result of make generate-examples)

@Machyne Machyne requested review from puckpuck and a team as code owners July 7, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants