fix: use part-of kubernetes label instead of instance in demo chart #1752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Kubernetes Recommended Labels docs say that instance should be a unique identifier for an instance of an application. Here, it's set to the helm installation name everywhere. I think
part-of
is more appropriate in this case.Using
instance
creates issues when scraping service labels per the semantic conventions: since noresource.opentelemetry.io/service.name
annotation is provided, this well known k8s labelapp.kubernetes.io/instance
is checked next. The result is that all of the data from the workload pods sent throughk8sattributes processor
using theservice.name
metadata will come out with the sameservice.name
(ex: "my-otel-demo" when using the example install command).If you think this is an issue with the semantic conventions, please let me know and I will take this discussion to that repo instead. Thanks in advance!
(note: this is a one-line diff on
charts/opentelemetry-demo/templates/_helpers.tpl
plus the result ofmake generate-examples
)