[opentelemetry-operator] allow for overriding namespace in values file #1758
+62
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CharlieTLe
force-pushed
the
operator-namespaceOverride
branch
5 times, most recently
from
289ab7b to
847bfa9
Compare
Signed-off-by: Charlie Le <[email protected]>
CharlieTLe
force-pushed
the
operator-namespaceOverride
branch
from
847bfa9 to
fc57f4b
Compare
|
Hi @TylerHelmuth, could you help review? |
jvoravong
reviewed
Jul 15, 2025
| {{- else -}} | ||
| {{- .Release.Namespace -}} | ||
| {{- end -}} | ||
| {{- end -}} |
There was a problem hiding this comment.
Namespace names have a char size limit of 63 I've seen users hit before, I'd suggest truncating the value based on the limit with something like this.
{{- default .Release.Namespace .Values.namespaceOverride | trunc 63 | trimSuffix "-" -}}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1755