Remove okhttp3 as dependency #1351 #1364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @driverpt! check out the discussion in #1061 also, it may be worth waiting for open-telemetry/opentelemetry-java#6546 to land and get released (cc @SylvainJuge) |
|
Is there an ETA when this can be reviewed and possibly merged? This is causing us some classpath hell in Micronaut + GraalVM |
are you asking about this PR, or open-telemetry/opentelemetry-java#6546? were you able to read through the concerns expressed in #1061? thanks |
|
This PR |
driverpt
force-pushed
the
aws-resource-remove-okhttp-3
branch
from
19c0b8f
to
58e1e54
Compare
|
I think this can move forward now using the new internal API that was introduced in open-telemetry/opentelemetry-java#6546 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removed Okhttp3 dependency. Okhttp3 brings Kotlin into the classpath and some of us do not want to bring Kotlin into the classpath as it creates "dependency hell"
Existing Issue(s):
#1351
Testing:
Tested Locally (No EKS Scenario) with OTLP Exporter
Documentation:
N/A
Outstanding items:
If someone could please test EKSResource and SSLSocketFactory, would be appreciated.