-
Notifications
You must be signed in to change notification settings - Fork 169
add declarative config support for AWS X-Ray #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
zeitlinger
wants to merge
5
commits into
open-telemetry:main
Choose a base branch
from
zeitlinger:declarative-config-xray-sampler
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
add declarative config support for AWS X-Ray #2296
zeitlinger
wants to merge
5
commits into
open-telemetry:main
from
zeitlinger:declarative-config-xray-sampler
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f958075 to
0f09056
Compare
Member
Author
laurit
reviewed
Oct 8, 2025
laurit
reviewed
Oct 8, 2025
...in/java/io/opentelemetry/contrib/awsxray/internal/AwsXrayRemoteSamplerComponentProvider.java
Outdated
Show resolved
Hide resolved
68a21c8 to
a6946bc
Compare
zeitlinger
commented
Nov 11, 2025
| @Override | ||
| public void afterAutoConfigure(OpenTelemetrySdk sdk) { | ||
| if (sdk instanceof ExtendedOpenTelemetrySdk) { | ||
| this.resource = ((ExtendedOpenTelemetrySdk) sdk).getResource(); |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is added in open-telemetry/opentelemetry-java#7832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-java-instrumentation#14323
Blocked by open-telemetry/opentelemetry-java#7832