migrate jmx-scraper to the new JmxTelemetry API#2446
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Nov 28, 2025
Merged
migrate jmx-scraper to the new JmxTelemetry API#2446trask merged 5 commits intoopen-telemetry:mainfrom
trask merged 5 commits intoopen-telemetry:mainfrom
Conversation
…ontrib into jmx-new-api
…ontrib into jmx-new-api
robsunday
reviewed
Nov 28, 2025
jmx-scraper/src/main/java/io/opentelemetry/contrib/jmxscraper/JmxScraper.java
Outdated
Show resolved
Hide resolved
…JmxScraper.java Co-authored-by: Robert Niedziela <175605712+robsunday@users.noreply.github.com>
trask
approved these changes
Nov 28, 2025
Merged
via the queue into
open-telemetry:main
with commit Nov 28, 2025
5e50152
46 of 51 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the introduction of
JmxTelemetry/JmxTelemetryBuilderin the new JMX Insights API (in open-telemetry/opentelemetry-java-instrumentation#15220), this PR migrates to the new API to prevent relying on internal implementation classes.There is however a limitation in this new API that prevents loading the "legacy" definitions in jmx-scraper. A simple workaround has been implemented by loading metrics definitions through a temporary file, this will be removed once the limitation is removed in instrumentation with open-telemetry/opentelemetry-java-instrumentation#15413.