-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code attributes to spring webflux controller spans and remove spring-webflux.handler.type
#12887
Merged
trask
merged 12 commits into
open-telemetry:main
from
cuichenli:capture-code-attributes-spring-webflux
Dec 20, 2024
Merged
Add code attributes to spring webflux controller spans and remove spring-webflux.handler.type
#12887
Changes from 5 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
24b443c
capture code.* resources attributes
cuichenli ee2c31e
remove redundant metric
cuichenli 8e8fbbb
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
cuichenli 33ec295
fix check style error
cuichenli 7043602
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
cuichenli e7381bb
update
cuichenli 1120ad8
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
cuichenli 807fd56
one more
cuichenli c1a5638
Update instrumentation/spring/spring-webflux/spring-webflux-5.0/javaa…
cuichenli d8d3837
update to get method name
cuichenli 3810623
Merge branch 'main' of github.com:open-telemetry/opentelemetry-java-i…
cuichenli 930f0f4
Merge branch 'capture-code-attributes-spring-webflux' of github.com:c…
cuichenli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously used
TestController
is more useful thanorg.springframework.web.method.HandlerMethod
that is reported after these changesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now it reports
TestController
as class name and method name ashandle
,TestController
does not have this method