-
Notifications
You must be signed in to change notification settings - Fork 979
Support extensions for attributesExtractors, contextCustomizers, operationListeners and spanNameExtractor #13917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
...api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
...api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/api/instrumenter/AttributesExtractorCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/api/instrumenter/ContextCustomizerCustomizer.java
Outdated
Show resolved
Hide resolved
...main/java/io/opentelemetry/instrumentation/api/instrumenter/ContextCustomizerCustomizer.java
Outdated
Show resolved
Hide resolved
We have a similar need (#13961). However, in our case we do not care about the specific server instrumentation. in our case we would like to have a header getter injected. |
...i/src/main/java/io/opentelemetry/instrumentation/api/internal/InstrumentationCustomizer.java
Outdated
Show resolved
Hide resolved
...ation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/ServiceLoaderUtil.java
Outdated
Show resolved
Hide resolved
0708c7d
to
f11181d
Compare
...es/distro/custom/src/main/java/com/example/javaagent/DemoInstrumenterCustomizerProvider.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
Open questions:
|
I think it's necessary to support distinguishing the type of instrumenter in same instrumentation. I are willing to explore related solution later. How about supporting it in a follow-up PR and providing current abilities for users firstly? I have refactored our inner Distro recently, I might need a bit more time to get started.
Sorry, I am not very clear about this point. Could you elaborate more about its background or purpose?
For this point, In fact, I haven't encouraged related requirement so far. I can file an issue to contain it and point one and set corresponding order. We could support them by order and requirement? |
Resolved #12250