Differentiate emitted metrics by configuration options #14018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13468
This change introduces another system property (
metaDataConfig
) that we can set during our test runs to help us identify awhen
condition for which the telemetry data is emitted. This way, we can run separate test suites in order to generate telemetry under different conditions and tag it accordingly.Example new metrics
.telemetry
file contents:Then, when we present the telemetry in the
instrumentation-list.yaml
file, we can differentiate when someone could expect to see the different telemetry. This provides a nice preview of the database semconv differences, as an example:I turned it on for a handful of the existing modules we were already collecting metadata for. I will follow this up with enabling it for every instrumentation I can find that emits metrics.
I also made some small changes to a few modules to setup the tests to run in a way that would be compatible with this setup (oshi, tomcat-jdbc, clickhouse)